-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix bug that cpu eviction does not take effect #1932
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1932 +/- ##
==========================================
+ Coverage 67.48% 67.51% +0.03%
==========================================
Files 420 420
Lines 46858 46865 +7
==========================================
+ Hits 31620 31641 +21
+ Misses 12941 12920 -21
- Partials 2297 2304 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
looks great! it will be better to add some ut for this.. |
50889c6
to
2c6eb07
Compare
Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-sh#1932) Signed-off-by: Wang Xiaoqiang <wangxiaoqiang@qiyi.com>
Ⅰ. Describe what this PR does
cpuset's value of sanbox container cloud always be set to all cpu ids of the machine by kubelet, if we use this value, the cpu eviction function will not take effect.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test